node-fasttext icon indicating copy to clipboard operation
node-fasttext copied to clipboard

upgrading fastText version

Open dcsan opened this issue 7 years ago • 2 comments

it seems that node-fasttext cannot use the models file that we generate from fastText binary itself.

I think there was a big change in the model format a few months ago, but it seems you are using a recent version of FT, but I'm not quite sure how to check the version.

technically they have only had one release https://github.com/facebookresearch/fastText/releases

not sure where this is defined:

FASTTEXT_VERSION = 12;

so I guess I have to check commit hashes against your version of the submodule? https://github.com/facebookresearch/fastText/commits/master

I see the same commit that you're using from back in dec 2017?

your repo image

ft repo image

so to update... I'm not 100% clear what to do 🙀

  • fork your repo
  • somehow update the sub-repo to change which version of FT pointing to
  • send you a PR
  • maybe publish a separate NPM module in case you don't have time to

do you see any problems with this or other steps I need to do?

dcsan avatar Aug 21 '18 09:08 dcsan

Thank you @dcsan

Yes, I updated this repo at the end of the year 2017. I am glad if you send a PR, i will pushlish a new version soon.

vunb avatar Aug 21 '18 09:08 vunb

OK I updated the version

https://github.com/vunb/node-fasttext/pull/19

however I see errors now trying to install on OS-X, will make a new issue

dcsan avatar Aug 23 '18 21:08 dcsan