vuetify icon indicating copy to clipboard operation
vuetify copied to clipboard

fix(memory): nuxt ssr memory leak fixes composable locale

Open memic84 opened this issue 2 years ago • 1 comments

Description

When using vuetify in Nuxt SSR, with high traffic there are memory leaks on certain objects. I was able to isolate those to the locale composable and fix them. Resolves 18393

Markup:

This repository can be used to reproduce: https://github.com/memic84/vuetify-memory-leak-reproduction

First you should link your local vuetify code with yarn link and yarn link "vuetify"

and then you can run Nuxt.

yarn && yarn build && node --inspect .output/server/index.mjs

To test the fix, link the PR code to the vuetify reproduction code.

Note

The leakage in locale composable led me to changing the reactive nature of isRtl and rtlClasses variables. I am not sure if this will cause problems, and if this is the correct way. If somebody has a better way, please let me know.

memic84 avatar Nov 28 '23 08:11 memic84

Can this be split into different PRs for theme and locale.

johnleider avatar Nov 28 '23 15:11 johnleider