vuetify icon indicating copy to clipboard operation
vuetify copied to clipboard

[Bug Report][2.6.12] Combobox 'allow-overflow' is not working

Open MayaElf opened this issue 3 years ago • 4 comments

Environment

Vuetify Version: 2.6.12 Vue Version: 2.6.11 Browsers: Chrome 106.0.0.0 OS: Windows 10

Steps to reproduce

  1. open Combobox
  2. put 'allow-overflow' = false
  3. and then for another combobox 'allow-overflow' = true

Expected Behavior

Behaviour is different for 'allow-overflow' = false vs =true

Actual Behavior

Behaviour is the same for 'allow-overflow' = false vs =true

Reproduction Link

https://codepen.io/MaiiaAfanaseva/pen/ZERQJXO?editors=1010

MayaElf avatar Nov 01 '22 11:11 MayaElf

What would the expected behaviour for false be. Allowing overflow would obviously mean that it scrolls when overflowed, which it does. But what would you want to happen when it is set to false?

Do you think that the scrolling should be removed, and instead all the items should be displayed without scrolling // kinda like setting the height to fit-content. Or should it just cut off the items that are overflowed?

Z3rio avatar Nov 02 '22 01:11 Z3rio

@Z3rio In Vuetify you have implementation of 'allow-overflow' for v-menu. I added it to examples in codepen https://codepen.io/MaiiaAfanaseva/pen/ZERQJXO?editors=1010 I believe the implementation for v-combobox should be the same as in v-menu.

MayaElf avatar Nov 02 '22 13:11 MayaElf

This was missed in f5a3f8296906fc63c87a60ca63c4ed9397bbe37c, and looks like it wasn't hooked up correctly even then. Since v1.2.0 the correct way to pass additional props to v-menu is through the menu-props prop.

KaelWD avatar Nov 02 '22 13:11 KaelWD

Okay, I will take a look at this.

Z3rio avatar Nov 02 '22 13:11 Z3rio

@KaelWD Sorry, my issue was about v-combobox. So in api-documentation for v-combobox 'allow-overflow' will be deleted?

MayaElf avatar Nov 04 '22 08:11 MayaElf

Yes, it extends VAutocomplete.

KaelWD avatar Nov 04 '22 08:11 KaelWD