fix(runtime): CSSVars can work with Teleport
close: #7312
see here bug seem still alive
I store the 'data-owner-value' in the 'parentComponent' when the element is unmounted, and reset it when it is updated. And maintain a variable 'teleportUTMap' globally, store 'ut', re-execute 'ut' when updating,
@baiwusanyu-c great work! but not working with this scenario
Do some refinement and unit testing tomorrow π€£
Deploy Preview for vuejs-coverage failed.
| Name | Link |
|---|---|
| Latest commit | f4a605c95dc31b29399aacef4b7bcdf24c7272a9 |
| Latest deploy log | https://app.netlify.com/sites/vuejs-coverage/deploys/639c7209abc1860008079a4f |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
1 Ignored Deployment
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| sfc-playground | β¬οΈ Ignored (Inspect) | Apr 6, 2023 0:44am |
Size Report
Bundles
| File | Size | Gzip | Brotli |
|---|---|---|---|
| runtime-dom.global.prod.js | 91.3 kB (+675 B) | 34.7 kB (+212 B) | 31.2 kB (+156 B) |
| vue.global.prod.js | 148 kB (+675 B) | 54 kB (+212 B) | 48.2 kB (+140 B) |
Usages
| Name | Size | Gzip | Brotli |
|---|---|---|---|
| createApp | 51.1 kB (+345 B) | 20 kB (+118 B) | 18.2 kB (+90 B) |
| createSSRApp | 54.4 kB (+345 B) | 21.3 kB (+103 B) | 19.4 kB (+134 B) |
| defineCustomElement | 53.4 kB (+345 B) | 20.7 kB (+108 B) | 18.9 kB (+140 B) |
| overall | 64.8 kB (+345 B) | 25 kB (+102 B) | 22.6 kB (+89 B) |
CodSpeed Performance Report
Merging #7344 will not alter performance
Comparing baiwusanyu-c:bwsy/fix/teleportCSSVars (e3e85d5) with main (bae79dd)
Summary
β
53 untouched benchmarks
/ecosystem-ci run
π Ran ecosystem CI: Open
| suite | result | latest scheduled |
|---|---|---|
| language-tools | :white_check_mark: success | :white_check_mark: success |
| nuxt | :x: failure | :white_check_mark: success |
| pinia | :white_check_mark: success | :white_check_mark: success |
| quasar | :white_check_mark: success | :white_check_mark: success |
| radix-vue | :white_check_mark: success | :white_check_mark: success |
| router | :white_check_mark: success | :white_check_mark: success |
| test-utils | :white_check_mark: success | :white_check_mark: success |
| vant | :white_check_mark: success | :white_check_mark: success |
| vite-plugin-vue | :white_check_mark: success | :white_check_mark: success |
| vitepress | :white_check_mark: success | :white_check_mark: success |
| vue-i18n | :white_check_mark: success | :white_check_mark: success |
| vue-macros | :white_check_mark: success | :white_check_mark: success |
| vuetify | :white_check_mark: success | :white_check_mark: success |
| vueuse | :white_check_mark: success | :white_check_mark: success |
| vue-simple-compiler | :white_check_mark: success | :white_check_mark: success |
Since this PR adds a new export to the @vue/runtime-core package, I think it should be shipped in a minor version.
The Nuxt test failure was due to this. Not a blocker, though.