faststore icon indicating copy to clipboard operation
faststore copied to clipboard

docs: Re-add wml instructions for linking @faststore/api

Open filipewl opened this issue 4 years ago • 5 comments

What's the purpose of this pull request?

In #1055 we added instructions on properly linking, due to duplicate instances of the graphql-js package, a local @faststore/api package to a store. However, that section got removed by mistake in #1060 while we were migrating the documentation.

This PR adds the instructions back into the CONTRIBUTING.MD file: https://github.com/vtex/faststore/blob/docs/wml/CONTRIBUTING.MD#linking-local-changes-from-faststoreapi.

References

  • #1055
  • #1060's https://github.com/vtex/faststore/commit/3aa669c2c766e49b14bd7abea6fde48937a1eba2#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L93-L114

filipewl avatar Mar 15 '22 15:03 filipewl

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50b8914713962da3064ea59f5ecc90d50f968505:

Sandbox Source
Store UI Typescript Configuration

codesandbox-ci[bot] avatar Mar 15 '22 15:03 codesandbox-ci[bot]

Those steps didn't work for me.

igorbrasileiro avatar Mar 15 '22 16:03 igorbrasileiro

@filipewl what is needed to merge this pr?

emersonlaurentino avatar May 30 '22 21:05 emersonlaurentino

@filipewl wands I think this PR is ready to merge. Can you try to trigger the CI again pls (checks incomplete 😞)?

hellofanny avatar May 31 '22 00:05 hellofanny

Hey! I need to re-test the steps because there's more to it than what is initially described (e.g. you also need to install Watchman and even then there are some issues with it). I'll go over the steps again, also test it with the NextJS repo, and will update the docs accordingly.

filipewl avatar May 31 '22 14:05 filipewl

Closing this as it's no longer needed now that we're using Turborepo. Thanks for the reminder @emersonlaurentino!

filipewl avatar Jan 13 '23 14:01 filipewl