store-components icon indicating copy to clipboard operation
store-components copied to clipboard

Product image sub component

Open IncognitaDev opened this issue 4 years ago • 6 comments

What problem is this solving?

This change allows to extract product main image swiper and pass any block to wrap it, this make easy the create float badges in main image.

How to test it?

import "product-images.main-swiper" block, pass as a children do another component, like stack-layout and pass as a children to product-images

Workspace

Screenshots or example usage:

image

IncognitaDev avatar May 20 '21 14:05 IncognitaDev

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [x] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar May 20 '21 14:05 vtex-io-ci-cd[bot]

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [ ] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar May 20 '21 14:05 vtex-io-docs-bot[bot]

In this page https://luis--iaqua.myvtex.com/produto-teste---com-variacao-copy-110-/p you could see I have a badge that has to be aligned exactly bellow at the image, in default implementation I cant control it because the thumbs is rendered in same block, and the, unaligned that badge, the same occur with the badges over image https://luis--iaqua.myvtex.com/produto-teste---com-variacao/p.

Of course, I will update the docs.

IncognitaDev avatar May 25 '21 12:05 IncognitaDev

This PR should be rebased with the master. Can you do it?

igorbrasileiro avatar Aug 05 '21 19:08 igorbrasileiro

This PR should be rebased with the master. Can you do it?

rebased 😄

IncognitaDev avatar Aug 11 '21 16:08 IncognitaDev

Re-Rebased

IncognitaDev avatar Oct 15 '21 18:10 IncognitaDev