cryptacular icon indicating copy to clipboard operation
cryptacular copied to clipboard

Issue 31+32

Open ememisya opened this issue 9 years ago • 8 comments

What's New?

  • Refactored asn package to decoder (as it does more than ASN now)
  • Added decoder for SSH2 RSA & DSA public keys (RFC-4253)
  • Added PemReader which validates and parses PEMs based on their respective RFCs
  • New utils to help with the features above

ememisya avatar Sep 12 '16 14:09 ememisya

Given there are API changes (major release), would you like for me to refactor so that I add the decoder package and leave asn alone for now, and perhaps we deprecate it and merge in the next major version release? Or would you rather we wait to merge this into the next major release? Or perhaps this merits a new major release?

ememisya avatar Sep 12 '16 14:09 ememisya

Looks good generally, but I'm concerned about moving existing components from the asn package to decoder. I don't think these changes merit a major version bump, so let's go with duplicating and deprecating for now.

serac avatar Sep 13 '16 11:09 serac

Pushed a4dfda3 with the changes.

ememisya avatar Sep 14 '16 19:09 ememisya

Pushed 4b09660 and dae85ea with the changes discussed.

ememisya avatar Sep 22 '16 20:09 ememisya

Any update on this? It's been a while :smile:

ememisya avatar May 05 '17 15:05 ememisya

I have a slight concern about effectively changing package names, but I think we've handled it fairly well via deprecation. I think that's relatively low cost for the functionality we get. @dfish3r do you have any concerns about accepting this work? I'm inclined to accept it. If you agree, I'll squash it down into a single commit and merge offline.

serac avatar Sep 12 '17 20:09 serac

Hi @dfish3r, just checking in on this branch. Any plans to move forward with the work?

ememisya avatar Jan 19 '18 23:01 ememisya

Hey guys, any news on this? Looks like it hasn't strayed far behind despite the time elapsed.

ememisya avatar Jan 14 '19 20:01 ememisya

So why wasn't this implemented?

ememisya avatar Mar 25 '24 14:03 ememisya