node-soap Allows SchemaElement instance to use import namespace as targetNamesp…

Allows SchemaElement instance to use import namespace as targetNamespace when the attribute is not set.

Prevents the following error message when schema elements do not include targetNamespace attribute:

Target-Namespace "undefined" already in use by another Schema!

If targetNamespace is declared by an import is used in a different schema, it overrides the value for the targetNamespace key.

Nov 07 '19 05:11 ndeniche

Coverage decreased (-0.5%) to 94.531% when pulling 79daeb4db5a57dccbc35d7d6b78dce5aa8c39559 on ndeniche:ndeniche_targetNamespace into af93a6f45720431371ab3f23866d3ad3f2efae1b on vpulim:master.

Nov 07 '19 05:11 coveralls

@ndeniche please fix the build and bring coverage back up.

Nov 14 '19 17:11 jsdevel

Same as the other added feature. All of the new code is covered. Should I improve coverage by adding tests to other features?

Nov 17 '19 02:11 ndeniche

@ndeniche if coverage drops on this build, that means that added code has decreased it right?

Nov 18 '19 18:11 jsdevel

Screenshot 2019-12-11 at 10 42 37 This really doesn't make much sense. The overall coverage dropped, but the coverage of each file increased?! 😲

Dec 11 '19 09:12 barboni

Was the test coverage on this resolved? Can it be merged soon?

Jan 31 '20 14:01 sfariaNG

@barboni it could be the case that this fix now makes other code unreachable: code who's past assumptions are no longer valid with this fix. can you look into it?

Feb 10 '20 20:02 jsdevel

I have the same problem as ndeniche and I don't have control over the WSDL. A fix would be appreciated.

Jul 21 '20 12:07 nicolasjolinUQAM

as long as coverage doesn't dip, we can merge the fix.

Jul 21 '20 16:07 jsdevel

It would be kindly appreciated !

Jul 21 '20 17:07 nicolasjolinUQAM

well, someone has to add a test. feel free to plagaraize this in a new pr with a test

Jul 21 '20 22:07 jsdevel