ColorPicker icon indicating copy to clipboard operation
ColorPicker copied to clipboard

Unused code in ColorWheel

Open tonyhallett opened this issue 4 years ago • 3 comments

This code can be deleted

https://github.com/vpapenko/ColorPicker/blob/59c078d0f2a2ecc35a6140f2d3b2c28401ca8514/ColorPicker/ColorPicker/ColorWheel.cs#L270

as is handled by the base class

https://github.com/vpapenko/ColorPicker/blob/59c078d0f2a2ecc35a6140f2d3b2c28401ca8514/ColorPicker/ColorPicker/BaseClasses/ColorPickerViewBase.cs#L78

tonyhallett avatar Jan 24 '22 11:01 tonyhallett

Specifically, WHAT code can be deleted?

From: Tony Hallett @.> Sent: Monday, January 24, 2022 3:54 AM To: vpapenko/ColorPicker @.> Cc: Subscribed @.***> Subject: [vpapenko/ColorPicker] Unused code in ColorWheel (Issue #60)

This code can be deleted

https://github.com/vpapenko/ColorPicker/blob/59c078d0f2a2ecc35a6140f2d3b2c28401ca8514/ColorPicker/ColorPicker/ColorWheel.cs#L270https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvpapenko%2FColorPicker%2Fblob%2F59c078d0f2a2ecc35a6140f2d3b2c28401ca8514%2FColorPicker%2FColorPicker%2FColorWheel.cs%23L270&data=04%7C01%7C%7C38f1c3593f0e4408f96f08d9df302e68%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786220302755130%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=j4%2FC124J7L5dcsRCGY1aASimaoUJ0CRjAKGsGOQKCcI%3D&reserved=0

as is handled by the base class

https://github.com/vpapenko/ColorPicker/blob/59c078d0f2a2ecc35a6140f2d3b2c28401ca8514/ColorPicker/ColorPicker/BaseClasses/ColorPickerViewBase.cs#L78https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvpapenko%2FColorPicker%2Fblob%2F59c078d0f2a2ecc35a6140f2d3b2c28401ca8514%2FColorPicker%2FColorPicker%2FBaseClasses%2FColorPickerViewBase.cs%23L78&data=04%7C01%7C%7C38f1c3593f0e4408f96f08d9df302e68%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786220302755130%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ICD88Ncos7PtTmKn5u%2BcBMdUDJ4s56fEjC7udOpOk54%3D&reserved=0

Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvpapenko%2FColorPicker%2Fissues%2F60&data=04%7C01%7C%7C38f1c3593f0e4408f96f08d9df302e68%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786220302765076%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=i60Yc0KH2%2B2wmL0kzN7%2FtwLsBnWbj2CMGq9xjFPUwkU%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADFAH7D2IGDFXABBOQUFCXDUXU4UXANCNFSM5MVFBODA&data=04%7C01%7C%7C38f1c3593f0e4408f96f08d9df302e68%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786220302765076%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UoJcso5VF6Zy2ujtRJ6gPqn6hNU%2FVcq7LFTeyzL7aGk%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.@.>>

IndianaGary avatar Jan 24 '22 18:01 IndianaGary

@IndianaGary I thought that the links were specific. The BindedIColorPicker_PropertyChanged method

tonyhallett avatar Jan 24 '22 20:01 tonyhallett

I'm working on a Maui port so I'll look into it.

Regards, Gary

From: Tony Hallett @.> Sent: Monday, January 24, 2022 12:44 PM To: vpapenko/ColorPicker @.> Cc: Gary Lewis @.>; Mention @.> Subject: Re: [vpapenko/ColorPicker] Unused code in ColorWheel (Issue #60)

@IndianaGaryhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIndianaGary&data=04%7C01%7C%7C22a9782272af4f2e7f5d08d9df7a4dd4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786538664123560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FjpbnrWx%2F5uQ%2FrVwIkXbHaVRLLfyKe1JrYaBf%2BnGfBs%3D&reserved=0 I thought that the links were specific. The BindedIColorPicker_PropertyChanged method

Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvpapenko%2FColorPicker%2Fissues%2F60%23issuecomment-1020530190&data=04%7C01%7C%7C22a9782272af4f2e7f5d08d9df7a4dd4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786538664133518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RjNy%2FdcTO%2FJ%2FtqXY5WTLAz%2FoDGJmN292oKAA0nP5l0U%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADFAH7E3MCIFYC4KOLXCSWLUXW22PANCNFSM5MVFBODA&data=04%7C01%7C%7C22a9782272af4f2e7f5d08d9df7a4dd4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637786538664143482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vE5ZlxflHABgj9rbAajsy%2BaaYMwgv06EffAElxHzOHg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.@.>>

IndianaGary avatar Jan 24 '22 23:01 IndianaGary