puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

ZendPHP support

Open jbh opened this issue 3 years ago • 1 comments

Description

This PR adds support for ZendPHP on its supported platforms.

This is accomplished by adding two parameters to php::globals:

  • Optional[Enum['community', 'zend']] $flavor
  • Optional[Hash] $zend_creds

Usage examples

class { '::php::globals':
  php_version => '8.1',
  flavor      => 'zend',
}->
class { '::php':
  fpm       => true,
  fpm_pools => {
    www => {
      listen => "127.0.0.1:9000",
    },
  }
}
class { '::php::globals':
  php_version => '5.6',
  flavor      => 'zend',
  zend_creds  => {
    'username' => '<USERNAME>',
    'password' => '<PASSWORD>',
  },
}->
class { '::php':
  fpm       => true,
  fpm_pools => {
    www => {
      listen => "127.0.0.1:9000",
    },
  }
}

jbh avatar Oct 25 '22 00:10 jbh

I'd like to expand the tests to include tests for this PR, but I can't seem to get the tests to run.

I've followed the instructions in the README:

bundle install --path vendor/bundle
bundle exec rake

but I keep getting this error about an undefined constant:

NameError: uninitialized constant PuppetStrings

module PuppetStrings::Tasks

Seems to be an issue within the puppet-strings gem. Any tips?

jbh avatar Oct 27 '22 17:10 jbh

Hello @jbh and thanks for the PR. You can read this document on how to run the spec suite

root-expert avatar Dec 12 '22 12:12 root-expert

Thanks. I've figured out how to get tests running. Just trying to find the time to write them now! Should have tests up by the end of the week.

jbh avatar Dec 12 '22 20:12 jbh

Sorry it took so long. I've added a few tests for the zend flavor.

jbh avatar Jan 09 '23 22:01 jbh

Just wanted to check in and see if there is any sort of ETA for peer review and acceptance? This has been sitting for awhile.

jbh avatar Jan 30 '23 19:01 jbh

Thanks for the review @kenyon. I'll get these sorted ASAP.

jbh avatar Feb 01 '23 20:02 jbh

I can't seem to get it to squash properly WITH a rebase... But your requested changes have been completed.

Now there are five of the exact same commit... Lol... Squashing is a lot harder than I remember.

jbh avatar Feb 02 '23 20:02 jbh

Okay! I finally got it squashed into one commit.

jbh avatar Feb 02 '23 20:02 jbh

Not sure how they got in there, but I've gotten CHANGELOG and REFERENCE taken out.

jbh avatar Feb 02 '23 21:02 jbh