fpm_pools option not working after release 7.0.0

[bovy89]

After this change, fpm_pools does not work anymore.

As consequence, this use case is broken too

Version 7.0.0:

class { 'php':
   ensure       => 'present',
   manage_repos => false,
   fpm          => true,
   dev          => false,
   composer     => false,
   pear         => true,
   phpunit      => false,
   fpm_pools    => {},
}

php::fpm::pool { 'www2':
    listen => '127.0.1.1:9000',
}

Created pools: www2 ---> correct

Afred 7.0.0:

class { 'php':
   ensure       => 'present',
   manage_repos => false,
   fpm          => true,
   dev          => false,
   composer     => false,
   pear         => true,
   phpunit      => false,
   fpm_pools    => {},
}

php::fpm::pool { 'www2':
    listen => '127.0.1.1:9000',
}

Created pools: www and www2 ----> wrong

[jcharaoui]

I can confirm this unexpected behavior. Parameter fpm_pools in the base class appears not to have any effect anymore.

[grant-veepshosting]

Perhaps this could be addressed by adding a knockout_prefix for the default www pool?

@jcharaoui if you refer to the linked commit above, the parameter 'php::fpm_pools' has moved to 'php::fpm::pools' instead, you'd need to change your Hiera data to reflect this.

[jouveits]

Furthermore, the default 'www' pool cannot be customized either using the php class.

For instance, this has no effect:

class {'::php':
  # ...
  fpm_pools => {
    'www' => {
      user => 'php',
      pm   => 'static'
    }
  }
}

[cedriclaudrel]

Can confirm, it's currently impossible to unset the default www pool without using Hiera or relying on overriding private classes parameters.

[bovy89]

This issue has been resolved in master (see #572), but a new release is required