node-github-publish icon indicating copy to clipboard operation
node-github-publish copied to clipboard

feat: add options.author

Open revolunet opened this issue 6 years ago • 5 comments

👋 Add support for options.author :

publisher.publish("log-YYMMAA", logContent, {
  message: 'some commit message',
  author: {
    name: 'Clint',
    email: '[email protected]'
  }
})

revolunet avatar Jan 03 '20 03:01 revolunet

Hi @voxpelli, any chance this can be merged ?

revolunet avatar Jan 21 '20 08:01 revolunet

Yes, absolutely, sorry for delay

voxpelli avatar Jan 21 '20 08:01 voxpelli

I think I would prefer to not just forward the author option but to actually pick the specific properties from it and just forward those. Then the API of this module doesn’t become coupled with the API of GitHub and accidental submits of extra data becomes impossible (if eg. one adds an object which implements author fields but also lots of other fields)

voxpelli avatar Jan 21 '20 08:01 voxpelli

Ok, i'm not sure ive understood correctly but heres a fix to only pick name and email

revolunet avatar Feb 13 '20 21:02 revolunet

Bump 😁

revolunet avatar Mar 17 '20 20:03 revolunet