Pelle Wessman

Results 795 comments of Pelle Wessman

Saying same here as in #294: Is anything broken in the current release and needs fixing for ESLint 7? This module automatically supports ESLint 7: https://github.com/mysticatea/eslint-plugin-node/blob/f45c6149be7235c0f7422d1179c25726afeecd83/package.json#L12-L14 So unless something is...

Is anything broken in the current release and needs fixing for ESLint 8? This module automatically supports ESLint 8: https://github.com/mysticatea/eslint-plugin-node/blob/f45c6149be7235c0f7422d1179c25726afeecd83/package.json#L12-L14 So unless something is broken, then this is a non-issue?

@mrtnzlml Great example! Can you add a dedicated issue for it, like a `ESLint 8.x regression: node/process-exit-as-throw no longer works`

@aladdin-add Can you summarize somewhere on how it relates to the ESLint 8 PR:s in this repo? What the changes are from upstream? + maybe links to PR:s for those...

As we need them for StandardJS as well, I think we can maybe add them there if we want a common org as well

Would it be possible to drop this down from a daunting 42 file change to something more narrowed and easier to review? Looks like most of the diff is to...

The smaller chunks the easier to review and to understand the scope, so yes, one PR per such scope would be nice 👍

👍 Same here, would love to help out to ensure that this stays up to date and can continue to support https://github.com/standard/standard

I don't think it would add much to do that change and its not strictly more correct. Only slight benefit would be to be able to indicate unsupported versions of...

Why do you want your own column names? Making things too configurable will make the module needlessly complex. I'm not sure I'm convinced of the benefit of adding this. >...