volta icon indicating copy to clipboard operation
volta copied to clipboard

OpenSSL version detection during install

Open xsrvmy opened this issue 3 years ago • 5 comments

This came up in #1150 twice already. The installer assumes that the version supplied by the openssl executable is the one to use, which can cause a problem if the openssl executable is not from the system, or if multiple versions of libssl are installed (no longer a problem with 3.0 support). Some better way of handling this is required. I think one of the following should work:

  • Detecting so names (doesn't the installer already do that afterwards anyways?)
  • Allowing the version to be overriden

xsrvmy avatar May 04 '22 14:05 xsrvmy

@xsrvmy Thanks for pulling this into its own issue. This is definitely a concern, especially with the linuxbrew example in the linked issue being a case where the openssl executable that runs isn't the system one. We don't do general soname detection, the installer has a specific case for CentOS systems, that have their own unique (custom-built) version of OpenSSL, so it detects that special case only.

Short-term, a version override (along with some docs about how to use it prominently linked somewhere) may be the easiest approach. More medium term, I have a draft PR out right now #1214 that switches to a statically-linked TLS implementation (also see https://github.com/volta-cli/rfcs/pull/47 for more background), which would sidestep this issue entirely.

charlespierce avatar May 04 '22 23:05 charlespierce

Is this the issue to watch as I am unable to install Volta at all on PopOS

jrock2004 avatar Jun 20 '22 22:06 jrock2004

Hi @jrock2004, I'm unfamiliar with PopOS. What is the error you are seeing when trying to install?

charlespierce avatar Jun 23 '22 23:06 charlespierce

It is the OpenSSL version mismatch. I went ahead and installed arch. Let me try booting into popos and see if issue remains.

jrock2004 avatar Jun 25 '22 02:06 jrock2004

@charlespierce Here is the error

volta-error

jrock2004 avatar Jun 25 '22 03:06 jrock2004