verl icon indicating copy to clipboard operation
verl copied to clipboard

[rollout] fix: RolloutConfig should support repetition_penalty config…

Open Lokiscripter opened this issue 2 months ago • 1 comments

…uration

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

During the rollout process, this configuration will be read from RolloutConfig. If it cannot be read, the default value is 1.0. However, if you try to configure this parameter in the YAML file, an error will occur because there is no such member in RolloutConfig.

image

Checklist Before Starting

  • [x] Search for similar PRs. Paste at least one query link here: ...
  • [x] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Lokiscripter avatar Dec 03 '25 06:12 Lokiscripter

@vermouth1992 hello,i saw a check failed,is this unrelated to the changes I submitted? Is it due to an unstable test environment or other issues? Could you please rerun the check?

Lokiscripter avatar Dec 04 '25 12:12 Lokiscripter

@Lokiscripter Some CI failed, please fix pre-commit and rebase your code to latest version

FightingZhen avatar Dec 06 '25 03:12 FightingZhen