verl icon indicating copy to clipboard operation
verl copied to clipboard

[WIP][megatron] feat: support discrete profiling for mindspeed

Open tardis-key opened this issue 3 months ago • 2 comments

What does this PR do?

  1. add role in annotate call for megatron_workers.py
  2. update doc

https://github.com/volcengine/verl/issues/4206

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • [x] Search for similar PRs. Paste at least one query link here: ...
  • [ ] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

tardis-key avatar Nov 24 '25 12:11 tardis-key

After configuring profiling for tests/speical_npu/run_qwen2_5_05b_grpo.sh, the profiling directory is as follows,

    • root | - actor_compute_log_prob | - actor_update | - ref_compute_log_prob

And the result of tests/speical_npu/run_qwen2_5_05b_grpo_mindspeed.sh are also consistent.

Due to an exception in collecting "generate" under AgentLoop, the "generate_sequences" folder was not obtained. This will be fixed in another PR.

tardis-key avatar Nov 26 '25 07:11 tardis-key

After configuring profiling for tests/speical_npu/run_qwen2_5_05b_grpo.sh, the profiling directory is as follows,

    • root | - actor_compute_log_prob | - actor_update | - ref_compute_log_prob

And the result of tests/speical_npu/run_qwen2_5_05b_grpo_mindspeed.sh are also consistent.

Due to an exception in collecting "generate" under AgentLoop, the "generate_sequences" folder was not obtained. This will be fixed in another PR.

Suggest fix the rollout period data unavailable error in this PR @tardis-key

FightingZhen avatar Nov 28 '25 03:11 FightingZhen

All review comments have been revised, and the pr has been rebased to latest code.

tardis-key avatar Dec 18 '25 03:12 tardis-key

After configuring profiling for tests/speical_npu/run_qwen2_5_05b_grpo.sh, the profiling directory is as follows,

    • root | - actor_compute_log_prob | - actor_update | - ref_compute_log_prob

And the result of tests/speical_npu/run_qwen2_5_05b_grpo_mindspeed.sh are also consistent. Due to an exception in collecting "generate" under AgentLoop, the "generate_sequences" folder was not obtained. This will be fixed in another PR.

Suggest fix the rollout period data unavailable error in this PR @tardis-key

https://github.com/volcengine/verl/pull/4320 is working on this. And that fix involves profiling of async inference engine and will take some time. As VeRL is to be released soon, it is recommended that this pr should be merged to enable the discrete profiling on MindSpeed.

tardis-key avatar Dec 18 '25 03:12 tardis-key