void-packages
void-packages copied to clipboard
samba: update to 4.20.1.
I don't have much experience with packaging and none with Void Linux packaging in particular, especially with a big project like Samba, so I'm not sure this is production ready yet.
Testing the changes
- I tested the changes in this PR: briefly
Local build testing
- I built this PR locally for my native architecture, x86_64-musl
- I built this PR locally for these architectures:
- x86_64
- aarch64
- aarch64-musl
Questions & notes
-
samba-libshas a ton of private libraries that I could not build as builtin this time. Should I add all of them tocommon/shlibs? EDIT I did add them all - I packaged
{uid,socket,nss,resolv}_wrappersince they are needed by thesambatestsuite but they can also be bundled in... Do we really need them? They are not used by anything else (yet). On the other hand,pam_wrapper, that is also needed, is already in the repository. - On a related note, I tried to build the aforementioned testsuite but it ended up with a
cmockarelated build failure (LargestIntegralTypewas not defined). It did build successfully whencmockawas build as a bundled library though. - Should we break the
sambapackage up? Fedora/Debian have a ton of subpackages for it and even Alpine has a few more than us.
I fixed the socket_wrapper patch, the tevent check I've not idea why it's failing, all the tests pass locally (x86_64-musl)
Fix the xlint error.
Nevermind, I disagree with xlint's error.
I'm also sorry to inform you that you're now the samba person.