New package: xpaint-3.1.4

[MIvanchev]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64-GLIBC)

[loosefish-scapegrace]

this works perfectly as far as I can tell

[github-actions[bot]]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[loosefish-scapegrace]

"github-actions[bot]" @.***> wrote:

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

bump

i've installed it and haven't come across any problems

[xeroxslayer]

This seems fine. I crossbuilt it to 7 arches, built just fine. I've installed it and it runs just fine on x86_64-musl (also tested with drawing and saving images).

Minor changes to the license in libXaw3dXft (MIT, X11 instead of just MIT) and the icon file for XPaint is not the same as in most distros (that is fixed in the PKGBUILD for Arch), but other than that, this is just fine.

I have those changes implemented in my templates. Should I just push the changes?

[MIvanchev]

@xeroxslayer I'll add the missing license info, thank you for the detailed review :raised_hands:. I use the icon directly from the package and this is the usual Void policy. Where are other distros sourcing the icon from?

[xeroxslayer]

@MIvanchev It's in the root of the source, XPaintIcon.xpm. Arch's template also fetches the modified .desktop file file from GH gist (have no idea why, a simple sed will do for the icon's location), but I just did this.

post_install() {
	vinstall XPaintIcon.xpm 0644 usr/share/pixmaps
	vsed -i ${DESTDIR}/usr/share/applications/${pkgname}.desktop -e 's|Icon=xpaint|Icon=/usr/share/pixmaps/XPaintIcon.xpm|'
}

[MIvanchev]

@xeroxslayer But why is the default desktop/icon combo problematic?

[xeroxslayer]

@MIvanchev No, not problematic at all. Just pointing out that most distros don't use that, that's all. In the end, it doesn't matter which icon is used. It's fine like this as well :). It works, that's what's important.

[MIvanchev]

@xeroxslayer Yes, ok, thank you, I understand. I think Void's policy is to trust the author's decision and I really don't know why any distro would just change the preset icon like that :) I've adjusted the licensing info.

[xeroxslayer]

Great :). Hope this gets merged soon.

[github-actions[bot]]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[github-actions[bot]]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

Bump.

[xeroxslayer]

Will probably need some patching, wchar_t to char, etc.

[MIvanchev]

It's more complex @xeroxslayer, the library defines something as char but uses it as wchar_t in some cases which is definitely wrong code and we have to think on how to make it right.

[xeroxslayer]

@MIvanchev Did something get depreciated in GCC 14, how did it pass before?

[MIvanchev]

Quite possibly @xeroxslayer because it doesn't build on Arch too: https://aur.archlinux.org/packages/xpaint#comment-980695. I'll patch it out just need to think about the best strategy.

[github-actions[bot]]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[MIvanchev]

bump.