vic icon indicating copy to clipboard operation
vic copied to clipboard

[No Review]Test hostname for vic

Open ading007 opened this issue 5 years ago • 1 comments

testing.

ading007 avatar Jun 01 '20 09:06 ading007

I don't think we should merge this as is. It was a hypothesis for bug2555488 - I've put the shortest path to fix that into the bug report.

This change is not sufficient on it's own. While the guestinfo conversion to volatile issue has been fixed, the semantics are still not correct for what we want. A docker rename will change the name while the VM is powered on, but modifying the value while the VM is powered on overlays a volatile value and when the VM powers off the value reverts. That leaves us with a renamed VM in VC inventory, but incorrectly reporting the old name via docker. The only option I can see to progress this approach is to have both this guest visible field, and the hidden field that can be modified while VM is powered on, with a check to copy from hidden to read-only that occurs after power off and during endpoint initialization. That's likely too heavy weight for the benefits at this time.

Fixing vmware/govmomi#2000 should be the priority, as without that it doesn't matter what the hostname is set to.

hickeng avatar Jun 01 '20 19:06 hickeng