vic icon indicating copy to clipboard operation
vic copied to clipboard

Remove integration test which references issue 1222 and close

Open mhagen-vmware opened this issue 9 years ago • 8 comments

I can't find an epic or implementation issue to work on the above support, so creating this. Close if we have a feature implementation issue already for this.

mhagen-vmware avatar Jun 27 '16 14:06 mhagen-vmware

@mhagen-vmware is there any context for this?

Searching the code found this.

/lib/apiservers/portlayer/models/scope_config.go: /* scope type ./lib/portlayer/network/context.go: return nil, fmt.Errorf("scope type not supported")

mdubya66 avatar Jun 29 '16 20:06 mdubya66

Sorry, I talked to @hmahmood when I made this and didn't translate our conversation into this issue: Yes, this is network related. You get this error when you run: docker ${params} network create -d overlay test-network2

This is mostly just a place holder for my test scripts until we decide we want to support this feature.

mhagen-vmware avatar Jun 30 '16 14:06 mhagen-vmware

NOTE: CLOSING THIS ISSUE MAY CAUSE AN INTEGRATION TEST FAILURE. Please re-enable the test in 1-15-Docker-Network-Create.robot as part of a PR to fix this issue. Please also ensure that the test passes cleanly. If the test needs improving or updating, please address it. Thx

corrieb avatar Jul 07 '16 19:07 corrieb

We are not going to support overlay networks for GA. Is this just a wording issue? i.e. do we need to change the error message?

hmahmood avatar Aug 08 '16 16:08 hmahmood

I am expecting something like the following error message, when I haven't setup an overlay network yet: #Should Contain ${output} Error response from daemon: failed to parse pool request for address space "GlobalDefault" pool "" subpool "": cannot find address space GlobalDefault (most likely the backing datastore is not configured)

mhagen-vmware avatar Aug 08 '16 17:08 mhagen-vmware

Moving to Icebox per 9/20 Triage. Needs release note.

mdubya66 avatar Sep 20 '16 21:09 mdubya66

Already in the release notes, so removing the kind/note tag.

stuclem avatar Nov 07 '16 17:11 stuclem

closing this impacts tests, Wending is trying a new pull request: https://github.com/vmware/vic/pull/8396

renmaosheng avatar Nov 23 '18 08:11 renmaosheng