versatile-data-kit icon indicating copy to clipboard operation
versatile-data-kit copied to clipboard

CI/CD misses dependency conflicts

Open doks5 opened this issue 3 years ago • 0 comments

Describe the bug As part of https://github.com/vmware/versatile-data-kit/pull/769, the click dependency in vdk-core and vdk-control-cli was updated to 8.X. The merge was successfull and no exceptions were raised.

However, the vdk-control-cli's setup.cfg file was missed, and this caused exceptions to be raised when doing new installations (https://github.com/vmware/versatile-data-kit/pull/770).

Steps To Reproduce Steps to reproduce the behavior:

  1. Change version of click in projects/vdk-control-cli/setup.cfg to 7.*
  2. Install vdk-core either from PYPI, or by moving into the vdk-core directory and executing pip install .
  3. Install vdk-control-cli by moving into its directory and executing pip install .
  4. See error

Expected behavior The CI/CD pipelines should have caught the dependency conflict.

Version (please complete the following information):

  • OS: All
  • Version vdk-control-cli 1.2.494451234 depends on click==7.* vdk-core 0.1.494451234 depends on click==8.*

Additional context N/A

doks5 avatar Mar 17 '22 13:03 doks5