versatile-data-kit icon indicating copy to clipboard operation
versatile-data-kit copied to clipboard

Add recovery support for job_input.execute_query() when fetching data

Open ivakoleva opened this issue 4 years ago • 0 comments

What is the feature request? What problem does it solve? User-facing execute_query API function invokes both - operation execution, then fetches the results to return. Recovery is supported currently on operation execution, however it is not yet supported when fetching results. See https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_connection_base.py#L111

Fetching results, as a part of the execute_query API, needs to also support recovery.

Suggested solution Extend fetchall() https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_cursor.py#L146 to support recovery, similar to execute() https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_cursor.py#L129

Acceptance criteria: fetchall() during execute_query() is recoverable.

ivakoleva avatar Nov 03 '21 15:11 ivakoleva