versatile-data-kit
versatile-data-kit copied to clipboard
vdk-oracle: test removing commit from ingest_payload
Overview
ingest_payload does a commit here https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py#L235
But we already call commit after every query https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_connection.py#L94
We should test if we need the commit in ingest_payload. Removing it and running the functional tests should be enough.
Acceptance criteria
- Remove the
commitcall. - Run functional tests.