versatile-data-kit icon indicating copy to clipboard operation
versatile-data-kit copied to clipboard

vdk-oracle: test removing commit from ingest_payload

Open DeltaMichael opened this issue 1 year ago • 0 comments

Overview

ingest_payload does a commit here https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py#L235

But we already call commit after every query https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_connection.py#L94

We should test if we need the commit in ingest_payload. Removing it and running the functional tests should be enough.

Acceptance criteria

  1. Remove the commit call.
  2. Run functional tests.

DeltaMichael avatar Feb 22 '24 14:02 DeltaMichael