Improve dateTime* type support
Use time.Time to represent dateTime* types (breaking change, but I think it makes sense)
Support dateTimeMicroseconds and dateTimeNanoseconds
Helpful pointers (besides RFC 7011): Timesamp handling in the Wireshark dissector for IPFIX NTP Timestamp format
@ivan4th, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.
Thank your contribution @ivan4th!
Since this is a performance-critical component and we're using it in another open source project at https://github.com/antrea-io/antrea/tree/main/pkg/agent/flowexporter, we may need more time to evaluate the performance impact from changing uint32 to DateTime type.
May I ask your purpose for this PR: just change the type to meet the RFC 7011 standard (actually dateTimeSeconds data type is an unsigned 32-bit integer according to https://www.rfc-editor.org/rfc/rfc7011.html#section-6.1.7)? Or you need DateTimeMicroseconds, DateTimeNanoseconds in your project?
Also, there are multiple test failures in the Github CI, could you please take a look at them? Please let us know if you need any help on refactoring the CI tests.
Thanks!
@ivan4th, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.