servicebinding icon indicating copy to clipboard operation
servicebinding copied to clipboard

Service Resources with non-obvious pluralization fails

Open Samze opened this issue 4 years ago • 5 comments

The service-binding controller uses this unsafe method to determine the GVR from the GVK to setup a watch dynamically. This method attempts to guess the GVR with some string checks and a lot of assumptions.

Unfortunately this Postgres Operator this fails inference of the pluralization. The plural is postgreses but just postgres.

This blocks this operator from being used with the binding operator. The only workaround is to use a direct secret reference.

cc @jpatel-pivotal


Note: Plural resource name for Postgres is postgres rather than the incorrect inferred postgreses

Samze avatar Nov 10 '21 17:11 Samze

New dynamic rest mapper a possible way to resolve this https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client/apiutil#NewDynamicRESTMapper. Will test it out ASAP!

rashedkvm avatar Nov 12 '21 22:11 rashedkvm

@rashedkvm any update on your testing?

scothis avatar Feb 15 '22 15:02 scothis

Not yet @scothis. It is on the priority list now 😀

rashedkvm avatar Feb 15 '22 15:02 rashedkvm

We should still fix this for real

scothis avatar Mar 08 '22 13:03 scothis

We will replace the tactical fix with a real fix and target for Service Bindings v0.7.2+

rashedkvm avatar Mar 08 '22 15:03 rashedkvm