pyvcloud
pyvcloud copied to clipboard
Fix AttributeErrors in nic methods
Fix a possible AttributeError in the following methods when NetworkConnection is not available:
-
vm.py:delete_nic() -
vm.py:update_nic()
Additionally, I applied the same variable names in update_nic() method as used in other nic methods and fixed the error message when nic was not found.
What do you think about this PR, @rocknes ?
Hey @Anirudh9794 or @rocknes
I'd like to kindly ask you to have a look at this PR, as these bugs are still not fixed.
Regarding the changes in update_nic(). There are actually not many:
- I renamed to variable and logic from
nic_foundtonic_not_foundas also used indelete_nic(), - I renamed to loop variable
nctonetworkas also used indelete_nic(), - I have improved the error message in
update_nic()analogous to the one used indelete_nic(), - I moved the method
update_nic()to the other nic methods.
Do you have any questions?
Hi @rocknes
Anything else I can do to get this PR merged?