dispatch icon indicating copy to clipboard operation
dispatch copied to clipboard

Support https for dispatchframework.io?

Open markpeek opened this issue 7 years ago • 5 comments

Does the new custom domain support for https mean we can support https for http://dispatchframework.io/ ?

markpeek avatar May 05 '18 22:05 markpeek

We don't use custom domains yet, it's just a redirect to vmware.github.io/dispatch. Are we ok to use custom domain?

kars7e avatar May 05 '18 23:05 kars7e

We're using an s3 hack to redirect "serverlessly" to pages. That's why dispatchframework.io is http-only, while the pages site is https. Not sure why we couldn't use the custom domain support.

berndtj avatar May 06 '18 17:05 berndtj

Ok, had to refresh my memory... since we are redirecting to a project site (i.e. https://vmware.github.io/dispatch) as opposed to a repository site (https://dispatchframework.github.io) we need the redirect.

Looks like we can add a cert though with the setup we have: https://simonecarletti.com/blog/2016/08/redirect-domain-https-amazon-cloudfront/

Or... we can move the docs to the dispatchframework repo (but I think that's a bad idea right now).

berndtj avatar May 06 '18 17:05 berndtj

I just thought it odd we didn't support both http and https through dispatchframework.io. Don't really care how it is implemented. But I'm fine with putting this off for now given the other tasks we have to do and enabling this in a month or two.

markpeek avatar May 06 '18 17:05 markpeek

I think we can support custom domain using CNAME file (https://help.github.com/articles/setting-up-an-apex-domain/). I was just concerned whether it's ok from the VMware Open Source standpoint, as no other project uses a custom domain for that.

kars7e avatar May 07 '18 19:05 kars7e