Vladimír Štill

> I think we should stick with whatever definition of uniqueness source info gives us for now. Just to keep things simple. Based on a program coverage view this behavior...

> > BTW. I've now realized this touches on something more complex still. For example, if there is a sub-control invoked from multiple controls (say in a multi-pipeline architecture, or...

I think that ideally, we would replace a lot of these with C++ ranges (although they are not a direct replacement in many cases I guess -- partially because Util::Enumerator...

@jnfoster I'm not sure I understand your comment, so I will try to explain myself a bit more. The idea is to have a testgen target that does not correspond...

> But this fixed target still demands a certain package structure, which could be constraining. A lot of the `p4test` test files in [testdata](https://github.com/p4lang/p4c/tree/main/testdata) have arbitrary package structure, for example....

> For some reasons these maps are wrapped into shared_ptr's, though I do not see where they are copied. `ForwardChildren` takes a reference to it. Could this be because of...

> `dontForwardChildrenBeforePreorder` I've come around a use case for that recently too. When IR is a DAG it is sometimes useful to see the old values in a transform, especially...

I understand this is an older issue, but it would be really helpful to have an example code that makes this problem visible.

Disclaimer: I wasn't there when most of this was designed. This is my opinion. > As a result, for example, --Wdisable=invalid will disable errors of type ERR_INVALID. Is this expected?...

> As a side note, the description for `--Werror` is "Report an error for a compiler diagnostic, or treat all warnings as errors if no diagnostic is specified." Does it...