automatic icon indicating copy to clipboard operation
automatic copied to clipboard

[Feature]: postprocessing operations UI - Show / Hide when enabled

Open brunogcar opened this issue 2 years ago • 4 comments

Feature description

when enabling postprocessing operations on System > Postprocessing

settings

it goes to Extensions tab

post3

what i propose it to move it to under the boxes to show / hide other modules (batch, seed, advanced, 2nd pass), for consistency as those are part of UI and not extensions or scripts, and to add a box to show / hide when enabled on settings

post3 post

adding that option to collapse that module will make UI cleaner when enabled, where user will just expand that when its needed, same as those other modules

Version Platform Description

Python 3.10.6 on Windows Version: app=sd.next updated=2023-09-17 hash=792893e6 Platform: arch=AMD64 cpu=AMD64 Family 25 Model 33 Stepping 2, AuthenticAMD system=Windows release=Windows-10-10.0.22621-SP0 python=3.10.6 nVidia CUDA toolkit detected

brunogcar avatar Sep 17 '23 20:09 brunogcar

Good suggestion, I'll take a look how clean it is to do it.

vladmandic avatar Sep 17 '23 21:09 vladmandic

i took a quick look and that legacy code is messy as hell. if someone wants to take a crack at it, i'd welcome a pr!

vladmandic avatar Sep 19 '23 02:09 vladmandic

i was going to suggest next, to add a feature i always thought was missing from SD, Aspect Ratio presets,

with similar features to expand/collapse to substitute existing extensions, but as being past of app, would be better positioned in UI, just below the sliders

made a draft, with links, etc but since it deals with same parts of the code, i guess it would be pointless ATM

brunogcar avatar Sep 19 '23 19:09 brunogcar

re: aspect ratio i guess they would calculate height based on set width?

its not the same code, so not really pointless. see screenshot - there is already switch width/height button, i think it can be moved just a bit higher and that leaves room for one more below it.

image

vladmandic avatar Sep 19 '23 19:09 vladmandic

this is no longer valid in the latest versions as that part has been pretty much rewritten. if there are remaining feature requests, please create/document new one.

vladmandic avatar Jan 15 '25 15:01 vladmandic