resolute icon indicating copy to clipboard operation
resolute copied to clipboard

fix: add unbonding period time to staking

Open charymalloju opened this issue 1 year ago • 2 comments

Summary by CodeRabbit

Release Notes

  • New Features

    • Dynamic display of unbonding periods for staking across various components, ensuring accurate information based on the selected chain.
    • Enhanced user interface for re-delegation and undelegation processes, including loading indicators for transactions.
  • Bug Fixes

    • Corrected method name from getAvaiailableAmount to getAvailableAmount for accurate functionality.
  • Enhancements

    • Added new utility functions for improved data handling and user interface interactions, such as formatting funds and handling network errors.

charymalloju avatar Sep 30 '24 04:09 charymalloju

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resolute ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 4:49am

vercel[bot] avatar Sep 30 '24 04:09 vercel[bot]

Walkthrough

The pull request introduces modifications across multiple components and a custom hook within the frontend application. Key changes include replacing hardcoded unbonding period values with dynamic values retrieved from a custom hook, ensuring accurate display of staking information. Additionally, minor adjustments were made to method names and UI elements to enhance user experience and functionality.

Changes

File Path Change Summary
frontend/src/app/(routes)/staking/components/DelegatePopup.tsx
frontend/src/app/(routes)/staking/components/NewDelegationDialog.tsx
frontend/src/app/(routes)/staking/components/ReDelegatePopup.tsx
frontend/src/app/(routes)/staking/components/UndelegatePopup.tsx
Updated unbonding period display to use dynamic values from singleStake.getChainUnbondingPeriod(chainID). Adjusted method names and improved UI responsiveness.
frontend/src/custom-hooks/useSingleStaking.tsx Added getChainUnbondingPeriod function to calculate unbonding periods dynamically and updated imports and effects.
frontend/src/utils/util.ts Introduced new utility functions and modified existing ones to enhance data handling and user interface interactions.

Poem

🐰 In the meadow, changes bloom,
Dynamic values chase away gloom.
Unbonding periods now take flight,
With hooks and functions shining bright.
A hop, a skip, the code aligns,
In the world of staking, all is fine! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b45426d19ff18217af41bcd4b92d869e4e1a7afe and f9746a2c8329c74330e6f94ee5466cb0228fd6c8.

📒 Files selected for processing (1)
  • frontend/src/custom-hooks/useSingleStaking.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/custom-hooks/useSingleStaking.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 30 '24 04:09 coderabbitai[bot]