vitest icon indicating copy to clipboard operation
vitest copied to clipboard

feat(config): deprecate `cache.dir` option

Open fenghan34 opened this issue 1 year ago • 4 comments

Description

Closes #3272

This PR removes the cache.dir option and reuses Vite's cacheDir to save cache.

Related

  • https://github.com/vitest-dev/vitest/pull/4036

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [x] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • [ ] Run the tests with pnpm test:ci.

Documentation

  • [x] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • [x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

fenghan34 avatar Feb 18 '24 13:02 fenghan34

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
Latest commit 8af373b7c8a066362b91de37736f00cfd89abfd6
Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65f3fecb5edb86000821e512
Deploy Preview https://deploy-preview-5229--fastidious-cascaron-4ded94.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 18 '24 13:02 netlify[bot]

Deprecating is not a breaking change as long as it's still resolved.

sheremet-va avatar Feb 20 '24 08:02 sheremet-va

Deprecating is not a breaking change as long as it's still resolved.

Aha...thanks for clarifying! As you said it's still resolved, do I need to handle cache.dir in resolving config? Like assigning Vite's cacheDir as cache.dir if it exists?

fenghan34 avatar Feb 20 '24 09:02 fenghan34

Deprecating is not a breaking change as long as it's still resolved.

Aha...thanks for clarifying! As you said it's still resolved, do I need to handle cache.dir in resolving config? Like assigning Vite's cacheDir as cache.dir if it exists?

Yes, I would expect cache.dir to affect the directory somehow until the option is removed completely in the next major.

sheremet-va avatar Feb 20 '24 09:02 sheremet-va