jsonapi_parameters icon indicating copy to clipboard operation
jsonapi_parameters copied to clipboard
verified publisher icon visualitypl

[WIP] Schema validator

Open michalksiazek opened this issue 5 years ago • 2 comments

Proposed change to not use ActiveModel::Validations.

TODO:

  • Test output of those validation errors
  • Meta and errors should be optional (currently validator returns that as schema errors)

michalksiazek avatar Jan 29 '21 14:01 michalksiazek

I already removed my previous comment; I didn't realize it was actually a request to merge into target PR.

Marahin avatar Jan 29 '21 15:01 Marahin

About meta and other optional keywords, if I remember correctly I've done that as manual change in the schema (basically making it less strict):

https://github.com/visualitypl/jsonapi_parameters/pull/45/files#diff-0b898c8dfb1316b8cc5b9fa193dd5bcea2d856082ea8777060f2b44e5b72225eR78

Try that, maybe that will resolve the issue.

Marahin avatar Jan 29 '21 15:01 Marahin