vf-core icon indicating copy to clipboard operation
vf-core copied to clipboard

Added initial implementation of loader - spinner

Open nitinja opened this issue 4 years ago • 10 comments

nitinja avatar Jul 22 '21 10:07 nitinja

I am working on eleventy page demo & react demo for this component

nitinja avatar Jul 22 '21 10:07 nitinja

✔️ Deploy Preview for ecstatic-noether-150ab4 ready!

🔨 Explore the source changes: 540597e5f3bf17df77ab71a5a1c490eecfeb005a

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/612ce107e240fd0007e2e9c2

😎 Browse the preview: https://deploy-preview-1631--ecstatic-noether-150ab4.netlify.app

netlify[bot] avatar Jul 22 '21 11:07 netlify[bot]

Eleventy page showing preview correctly in dev mode, but not on deployed preview image

nitinja avatar Jul 22 '21 11:07 nitinja

@khawkins98 @nitinja just curious to know if we can build our own EMBL style loader/spinner instead of standard one.

Like we can use the hexagon icon of logo and circle around it animated effect.

https://monophy.com/gifs/embl-embllogo-embllogomonochrome-SU8RkgEO4bcb9bL1U9

https://www.embl.org/news/wp-content/uploads/2014/09/embl_virus_logo_animation_5sec.gif

sandykadam avatar Jul 22 '21 11:07 sandykadam

Animation

nitinja avatar Jul 22 '21 12:07 nitinja

Ah looks nice 👍

sandykadam avatar Jul 22 '21 13:07 sandykadam

Looking good @nitinja — I did have a few minor things that I've noted.

khawkins98 avatar Jul 27 '21 16:07 khawkins98

Looking good @nitinja — I did have a few minor things that I've noted.

Are we good to use hexagon style or grey circle loader

sandykadam avatar Jul 27 '21 16:07 sandykadam

@sandykadam I have committed just the circle spinner as of now, I think we can't commit any design that's not approved by UX people.

nitinja avatar Jul 28 '21 06:07 nitinja

Adding a note here that based on our recent conversation with @cindyebi and @nitinja this will be part of vf-progress-indicator, and specifically a vf-progress-indicator--spinner variant.

khawkins98 avatar Sep 08 '21 12:09 khawkins98