ruby_odata icon indicating copy to clipboard operation
ruby_odata copied to clipboard

Allow reconfiguring Faraday with block and explain NTLM auth.

Open steventebrinke opened this issue 9 years ago • 2 comments

Updates the OData Service to allow passing it a block that is called when Faraday is initialised. This allows more advanced configurations such as NTLM auth, of which I give an example in the README. (Since NTLM auth with Faraday is undocumented, my way of using it might not be the best. Therefore, this code is kept outside the OData library, so other ways of reconfiguring Faraday are also possible.)

steventebrinke avatar Oct 14 '16 13:10 steventebrinke

I'm so sorry that I missed this pull request. Great job! The one thing I'd like to see is some specs testing out NTLM auth. I love the README addition, that will help a lot of users. I plan on rolling out a new version and would like to add this. Do you have time to add some specs?

visoft avatar Aug 08 '17 22:08 visoft

I pulled your changes in the develop branch, but a bunch of specs failed. I didn't check anything into GitHub. Could you revisit the changes against the develop branch?

visoft avatar Aug 08 '17 23:08 visoft