netlink icon indicating copy to clipboard operation
netlink copied to clipboard

Support STP parameters in bridge

Open daniel-noland opened this issue 4 years ago • 7 comments

Added basic support for some basic spanning tree protocol configuration parameters on the bridge device.

daniel-noland avatar Mar 28 '21 22:03 daniel-noland

Notes:

  1. I am very new to Go, so if I am deviating from any idioms or best practices please let me know and I will do my best to correct.
  2. When I run the full go-netlink test suite some of the tests fail due to parameter off-by-one issues. I am running linux kernel 5.11.10 at the time of writing. I don't know why this is happening for me but I will assume this is not happening elsewhere until I dig in a little more and find out what is going on. I mention this here because I deliberately wrote a couple more tests which fail for similar off-by-one issues under the assumption that they won't fail on other machines. I am leaving this as a draft PR till I find out what is going on.

daniel-noland avatar Mar 28 '21 22:03 daniel-noland

Warning:

My colleague ran the tests I included in this patch on his machine (running linux kernel 5.4) and all tests pass.

I am upgrading this PR from draft in the hopes that others will run the tests included in this patch and confirm.

I suggest that we make a point of running this test suite on various linux kernels.

The tests fail for me on kernel 5.11.10

The failure symptom is that all timer values I specify are accepted by the kernel (assuming they were otherwise valid). However, on query every timer is reported as the specified value less one. E.g., if I specify the max age stp parameter as 200 then the operation is is accepted but on querying the current value it returns as 199.

daniel-noland avatar Apr 02 '21 14:04 daniel-noland

also pls push again so CI is triggered

aboch avatar May 08 '21 15:05 aboch

ping...

aboch avatar Sep 18 '21 01:09 aboch

Looks like the tests are failing in CI here

vishvananda avatar Jan 12 '22 22:01 vishvananda

@daniel-noland

aboch avatar Jul 03 '24 20:07 aboch

@daniel-noland

aboch avatar Aug 23 '24 19:08 aboch

Closing due to inactivity. Feel free to reopen.

vishvananda avatar Sep 02 '25 19:09 vishvananda