math.gl icon indicating copy to clipboard operation
math.gl copied to clipboard

fix(polygon): Improve speed of Polygon.getSignedArea()

Open ibgreen opened this issue 1 year ago • 2 comments

  • Trying to replicate @smcallis promising results in https://github.com/visgl/deck.gl/discussions/9089#discussioncomment-10361993

ibgreen avatar Aug 17 '24 15:08 ibgreen

Pull Request Test Coverage Report for Build 10433413865

Details

  • 14 of 36 (38.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 84.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/polygon/src/polygon-utils.ts 7 29 24.14%
<!-- Total: 14 36
Totals Coverage Status
Change from base Build 10433220835: -0.1%
Covered Lines: 14813
Relevant Lines: 17606

💛 - Coveralls

coveralls avatar Aug 17 '24 15:08 coveralls

Sweet thanks for trying to get this upstreamed.

smcallis avatar Aug 17 '24 16:08 smcallis