Catch ThreadInterruptedException in Server.cs when closing stream/client in SendLoop
These were getting through and logging as errors when client disconnects due to socket exceptions, trying to match functionality with ThreadAbortException.
It's possible this isn't the only scenario where a ThreadInterruptedException is thrown though? Maybe we do still want to log it?
@darrencperry is there an easy way to reproduce it?
and what do you mean with 'it still gets through to here when aborting'? - aborting what exactly?
It's not easy to reproduce without a temperamental network.
That line you quoted is just copied from the above exception comment, I'm just trying to replicate the functionality of that error but I'm not 100% on whether a thread interrupted exception should be treated the same way as thread aborted exception.
I can't do much more on this in the near future as our project moved over to Ignorance, sorry!
sorry, didn't have time for telepathy in a while. can you confirm that the issue still exists in the latest version? did a major rewrite in 2021 :)
sorry, I'm not working with Telepathy or Mirror any more so I won't be able to do any more work on this, this pr solved an issue I was having at the time but feel free to close it, thanks!