Telepathy icon indicating copy to clipboard operation
Telepathy copied to clipboard

Catch ThreadInterruptedException in Server.cs when closing stream/client in SendLoop

Open darrencperry opened this issue 6 years ago • 8 comments

These were getting through and logging as errors when client disconnects due to socket exceptions, trying to match functionality with ThreadAbortException.

It's possible this isn't the only scenario where a ThreadInterruptedException is thrown though? Maybe we do still want to log it?

darrencperry avatar May 15 '19 14:05 darrencperry

@darrencperry is there an easy way to reproduce it?

miwarnec avatar Jun 21 '19 10:06 miwarnec

and what do you mean with 'it still gets through to here when aborting'? - aborting what exactly?

miwarnec avatar Jun 21 '19 10:06 miwarnec

It's not easy to reproduce without a temperamental network.

That line you quoted is just copied from the above exception comment, I'm just trying to replicate the functionality of that error but I'm not 100% on whether a thread interrupted exception should be treated the same way as thread aborted exception.

I can't do much more on this in the near future as our project moved over to Ignorance, sorry!

darrencperry avatar Jun 21 '19 10:06 darrencperry

sorry, didn't have time for telepathy in a while. can you confirm that the issue still exists in the latest version? did a major rewrite in 2021 :)

miwarnec avatar Feb 04 '21 04:02 miwarnec

sorry, I'm not working with Telepathy or Mirror any more so I won't be able to do any more work on this, this pr solved an issue I was having at the time but feel free to close it, thanks!

darrencperry avatar Feb 04 '21 07:02 darrencperry