UKCensusAPI icon indicating copy to clipboard operation
UKCensusAPI copied to clipboard

Test failure

Open virgesmith opened this issue 6 years ago • 2 comments

One of the tests in test_get_proj_data has started to fail:

Traceback (most recent call last):
  File "/mnt/data/home/az/dev/UKCensusAPI/tests/test_all.py", line 206, in test_get_proj_data
    self.assertEqual(sum(table.OBS_VALUE), 592012)
AssertionError: 592842 != 592012

Nomisweb must have very recently updated the (retrospective) 2001 MYE data, although according to this page https://www.nomisweb.co.uk/query/construct/summary.asp?menuopt=200&subcomp= (as on 1/7/19) there has been no update for a year.

It kind of defeats a major point of UKCensusAPI which is to guarantee the uniqueness of the data by cacheing it against a hash of the exact query, with the aim of ensuring reproducibility.

FWIW I shall post a link to this on the nomisweb forum and ask about versioning their datasets. They do have a query param that defaults "date=latest" but the query builder doesn't seem to document this

["Fixed" by updating the expected result in the test.]

virgesmith avatar Jul 01 '19 08:07 virgesmith

See https://www.nomisweb.co.uk/forum/posts.aspx?tID=587&fID=2

virgesmith avatar Jul 01 '19 08:07 virgesmith

Hi,

I'm senior software developer at Nomis - just dropping a comment here to let you know I've replied to your forum post on our site (https://www.nomisweb.co.uk/forum/posts.aspx?tID=587&fID=2).

Looks like an interesting project you have up and running here, it's always good to see the API being used in the wild. If you have any further problems or don't fully understand my reply, please get in touch.

Regards, Spencer

SpencerHedger avatar Jul 01 '19 14:07 SpencerHedger