vimperator-labs icon indicating copy to clipboard operation
vimperator-labs copied to clipboard

#587 commit causes autocomplete delay.

Open ghost opened this issue 9 years ago • 6 comments

Issue type:
  • Bug report
Version:
<!-- (Paste the output of `:version` here) -->
Vimperator: 3.15.0 (created: 2016/10/08 06:55:36)
Firefox:    Mozilla/5.0 (X11; Linux i686; rv:50.0) Gecko/20100101 Firefox/50.0
Description:

When i updgraded vimperator to version 3.15 i discovered constant lagging when i tried work with commandline. For example, when i type ab and try to autocomplete that to about:support, with pressing Up only once, it's autocompletes with delay.

I found commit that was cause of it and compile without it, and it's gone: https://github.com/vimperator/vimperator-labs/pull/587

ghost avatar Oct 08 '16 00:10 ghost

~~With a fast machine this is only slightly noticeable, but you are able to notice it. On a slower machine I observed a rather long lag.~~

~~Maybe it's the regular expression matching that slows it down.~~

~~Until a solution is found I suggest to revert 52b7f94e46dd09057e30c9c62e2f3233d68c5eb2.~~

Now I cannot reproduce it anymore. Maybe something else. :/

SammysHP avatar Oct 19 '16 22:10 SammysHP

But it still seems to be here for @stepshal and probably others? If this commit is really the cause, I am for reverting it. Working on the commandline should always be fast.

maxauthority avatar Oct 20 '16 09:10 maxauthority

@maxauthority Yes, i am for reverting it. For some reason with current build first entry is autocompletes without lag, but if you try to autocomplete to the next, lag is still here.

ghost avatar Oct 20 '16 10:10 ghost

@stepshal That is interesting. Can you please describe exactly what you do to reproduce this?

I think it's not the completion but the history that became slower. And I tried it on an old (=slow) computer and can reproduce it with this sequence:

  1. Press :set
  2. Press multiple times, each results in a slight delay

After reverting 52b7f94e46dd09057e30c9c62e2f3233d68c5eb2 it is fast again.

SammysHP avatar Oct 20 '16 11:10 SammysHP

Maybe it is history. For me:

  1. Press :tabopen
  2. Type ab
  3. Press to autocomplete to about:pages, each result in a 1 second delay (3.15 version), and only after first entry delay appears (master). And youtube.com was freezing each time i open it for a long time for some reason with it.

ghost avatar Oct 20 '16 11:10 ghost

@timss maybe just revert this commit?

ghost avatar Dec 03 '16 01:12 ghost