express-http-proxy icon indicating copy to clipboard operation
express-http-proxy copied to clipboard

Asynchronous "getHost" implementation. #284

Open maxstrauch opened this issue 7 years ago • 3 comments

Solves the problem that the getHost function callback cannot be async.

maxstrauch avatar Dec 21 '18 17:12 maxstrauch

hey @maxstrauch, Thanks for this patch. Currently this library is designed to be backward comparable with node 6, and so async is not a supported approach in the source code. You can see that the tests failed for node 6, and if you look at the failure log, it will provide more detail.

I would accept a patch written in Promises form and with a test or two.

Thanks again

monkpow avatar Dec 22 '18 20:12 monkpow

@monkpow I saw it too late that this lib want's to be backwards compatible and I didn't notice it when looking at the code since I only develop in ES6 or Typescript lately ;-)

I'll see what I can get done over the holidays ;-)

maxstrauch avatar Dec 22 '18 22:12 maxstrauch

Fixed with Node 6 support here: https://github.com/villadora/express-http-proxy/pull/420

bconnorwhite avatar Sep 01 '19 15:09 bconnorwhite