Viktor Todorov

Results 54 comments of Viktor Todorov

> I've proposed the addition of a shellcheck step in the static-analysis check: #702 > > I think it would be desirable to merge that PR first so that this...

I believe I've resolved the comments and shellcheck issues. Only one type is left: ``` In examples/tokenvm/scripts/tests.load.sh line 12: source ../../scripts/common/utils.sh ^---------------------------^ SC1091 (info): Not following: ../../scripts/common/utils.sh was not specified...

@marun There are a lot of conficts and I've already gone through the pain of resolving them and making sure that I don't regress the code. I don't want to...

Conflicts are resolved.

### Sync tests Sync tests should be fixed. ### Morpheusvm/Tokenvm lint I'm honestly not sure why linting ci throws such an exception. When ran locally I get: ``` cmd/morpheus-cli/cmd/key.go:14:2: import...

@marun, hey, sorry for the delayed response. I wanted to answer you but somehow it slipped away. > The trick is to use an absolute repo-rooted path in the override...

@marun, resolved and merged main. Let's try running the CI one more time?

@marun, this time it should pass... 🤞 1. I've downgraded golangci-lint 2. Fixed the unit test CI issue by separating the unit testing script logic because of the changes in...

@marun, can we run the CI one more time? > I'm starting to wonder if the lint changes shouldn't be broken out into a separate PR. There are apparently changes...

After the last commit, all check except HyperSDK Unit Tests should pass. Regarding this failing action, I believe it's not related to my changes, as can be seen from another...