http-streaming icon indicating copy to clipboard operation
http-streaming copied to clipboard

Use the tech directly instead of holding references to text tracks in SegmentLoader

Open ldayananda opened this issue 7 years ago • 1 comments

We currently have this in SegmentLoader, which essentially holds references to text tracks created or referenced by the project:

https://github.com/videojs/http-streaming/blob/21e5335136f714f3783cb5a37d9f06173fbbd9e4/src/segment-loader.js#L171

It would be safer to access the tech directly to access these tracks as they could be removed from the video element by an external project, via the API, e.c.t. We could instead hold onto the ids of the textTracks we created, and use that to request textTracks from the tech.

ldayananda avatar Sep 07 '18 16:09 ldayananda

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome[bot] avatar Sep 07 '18 16:09 welcome[bot]