gitpunch icon indicating copy to clipboard operation
gitpunch copied to clipboard

Add an option to skip notifications for "pre-release"

Open crazy-max opened this issue 7 years ago • 7 comments

Hi,

Today we receive notifications for pre-release : https://github.com/brave/browser-laptop/releases/tag/v0.25.203

image

Is it possible to add an option to skip notifications for these ?

crazy-max avatar Oct 29 '18 21:10 crazy-max

+1 on that 👍 Especially with Brave 😅

Jacalz avatar Oct 31 '18 13:10 Jacalz

im basically done with this feature, you'll be able to subscribe to major & minor releases only, meaning any release that matches pattern *.*.0

i want to properly cover all the usecases with end-to-end tests before i deploy it, which will take some time, probably this week i'll finish

vfeskov avatar Oct 31 '18 13:10 vfeskov

Awesome @vfeskov ! Thanks a lot

crazy-max avatar Oct 31 '18 15:10 crazy-max

done, will describe in release notes

vfeskov avatar Nov 03 '18 13:11 vfeskov

Hi @vfeskov, unfortunately this implementation did not solved my issue. Like I said, I was thinking to check the release status (draft, pre-release, release) :

image

Where :

  • release = !release.draft && !release.prerelease
  • prerelease = release.prerelease
  • draft = release.draft

crazy-max avatar Nov 09 '18 08:11 crazy-max

thing is im not using github api because of rate limiting, im using atom feeds, e.g., https://github.com/angular/angular/releases.atom , and i think it doesn't have those flags, does it?

vfeskov avatar Nov 09 '18 13:11 vfeskov

Ok legit, I understand the limitation. And unfortunalety, you right there is no evidence for these flags in ATOM feeds :persevere:

crazy-max avatar Nov 09 '18 13:11 crazy-max