CMSish icon indicating copy to clipboard operation
CMSish copied to clipboard

Full width/height background images issue

Open e-g-b opened this issue 8 years ago • 3 comments

When I wrap the script around my HTML, I'm no longer able to render full width/height background images. I now have to give it a hard pixel dimension. If I remove the script tag wrapped around my HTML, full width/height background images work again. Any ideas?

e-g-b avatar Apr 19 '17 20:04 e-g-b

Hi e-g-b, thanks for trying CMSish!

Strange, I can't seem to replicate the bug. On the demo site, I seem to be able to set background images on the body element or #content element: http://verticalgraindesign.com/CMSish/demo

Would it be possible to send me a link to your demo site to take a look?

verticalgrain avatar Apr 19 '17 20:04 verticalgrain

I figured out a solution, just set the BG position to fixed and gave the BG size a min-width and min-height. Weirdly though, if I remove the fixed position, the same things happens where the background image disappears and has a 0px height. Again, if I remove the script tag from around my HTML, the background image displays fine. I have this BG img set on a div (not on the body), for a hero spot at the top of the page. I have it in my local env., couldn't really share the page since it's for my company. I figured out a work around, although don't like using the fixed position, but it works. Just thought it was weird that wrapping the HTML with the script was causing issues. Thanks for creating a really simple to use solution like CMSish! I dig it!

e-g-b avatar Apr 19 '17 22:04 e-g-b

It sounds to me like a CSS issue. If you could create a codepen with some code to look at, I'd love to help you get the background image working without needing to use fixed position.

Thanks for trying CMSish and please let me know if you have any suggestions for improvements!

verticalgrain avatar Apr 20 '17 00:04 verticalgrain