mediasoup icon indicating copy to clipboard operation
mediasoup copied to clipboard

Fix installation under path with whitespaces

Open nazar-pc opened this issue 4 years ago • 4 comments

Bug Report

Your environment

  • mediasoup version: 3.9.4

Issue description

When installed under directory whose path has whitespaces, installation fails, see https://mediasoup.discourse.group/t/mediasoup-installation-issue-ubuntu-20-04-node-16-13-1-pip-21-3-1-python-3-8-10/3804, we need to fix that.

nazar-pc avatar Jan 11 '22 17:01 nazar-pc

Is this a bug in our code or in some underlying lib or build system?

ibc avatar Jan 11 '22 20:01 ibc

I believe some paths need to be taken into quotes in the Makefile, didn't dig into details yet, so it is all on our side.

nazar-pc avatar Jan 11 '22 20:01 nazar-pc

Creating Mediasoup Files in using other other local disk space in Dual Boot

Basically i am on Dual boot and using other local disk space 'Volume/Backend/mediasoup/mediasoup-3' so maybe thats why i was facing that issue that time

But as @nazar-pc said for changing directory i clone that repo. in Desktop and same process and issue resolved but getting some warning

Link of warning of C in Mediasoup Discourse image

hope Mediasoup Team will fix these also

And Thanks for this helping Community

i will ask more Questions in future

techhjork avatar Jan 12 '22 09:01 techhjork

The whitespace is a feature I thought?

CosmosisT avatar Apr 18 '22 17:04 CosmosisT

When installed under directory whose path has whitespaces, installation fails, see https://mediasoup.discourse.group/t/mediasoup-installation-issue-ubuntu-20-04-node-16-13-1-pip-21-3-1-python-3-8-10/3804

@nazar-pc the linked post doesn't seem related to having white spaces in the installation path, do I miss something?

ibc avatar Dec 10 '22 10:12 ibc

It does, see, target is /media/tech/New Volume/Backend/mediasoup/mediasoup-3/worker/out/pip, then you see "invalid requirement", which is suspiciously the part of the path after whitespace:

ERROR: Invalid requirement: 'Volume/Backend/mediasoup/mediasoup-3/worker/out/pip'

nazar-pc avatar Dec 10 '22 10:12 nazar-pc

I've tried everything and this is hell. Not even sure there is a fix, and impossible to fix it in all OS.

So I've fixed this issue another way:

CleanShot-2022-12-10-at-13 21 51@2x

ibc avatar Dec 10 '22 12:12 ibc

I'm sure there is a fix, but not sure we want it in the codebase. Not supporting whitespaces is certainly one way to "fix" it :joy:

nazar-pc avatar Dec 10 '22 12:12 nazar-pc

Searching for "Makefile whitespaces" is just maddening. I just gave up. Add I love the fix 😅

ibc avatar Dec 10 '22 12:12 ibc

I would not say this issue has been resolved. I had a whitespace in my Filepath and it didn't work, when the whitespace was removed - it worked.

RamanSB avatar Nov 10 '23 14:11 RamanSB

Yes. As explained in comments above we gave up. And we documented that the installation path cannot have white spaces. PRs are welcome, we don't know how to fix that.

ibc avatar Nov 10 '23 14:11 ibc

This is probably fixed in PR https://github.com/versatica/mediasoup/pull/1239/ in commit https://github.com/versatica/mediasoup/pull/1239/commits/c7720f2da4f399a81d1b482cf28d8d604207ff19.

ibc avatar Nov 26 '23 21:11 ibc