plasio icon indicating copy to clipboard operation
plasio copied to clipboard

Scope for code optimization

Open mghildiy opened this issue 7 years ago • 1 comments

Hi,

In render.js:

Inside for loop in ParticleSystemBatcher.prototype.push

var x = p.position[0] * lasBuffer.scale[0] + lasBuffer.offset[0]; Later on: positions[ 3*i ] = p.position[0] * lasBuffer.scale[0] + (lasBuffer.offset[0] - this.corrective.x); This is same as: positions[ 3*i ] = x - this.corrective.x

Similar for y and z coordinates.

With huge number of points, avoiding this recomputation may help in improving the performance.

PS:If permitted, I can commit this change.

mghildiy avatar Apr 25 '18 13:04 mghildiy

Please submit a PR and we can take it from there.

verma avatar Apr 25 '18 19:04 verma