turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Return 0 exit code from 'turbo-ignore'

Open mehulkar opened this issue 2 years ago • 5 comments

Discussed in https://github.com/vercel/turbo/discussions/5647

Originally posted by Tobjoern July 31, 2023 From my current view, turbo-ignore returns the exit code '1' is a proejct changed, and '0' if it didn't. Is there a specific reason behind this?

It leads to some very weird patterns, when integrating into a CI/CD system, epeciall with GH actions, since the immediately fail, whenvever a non-0 code is emitted. But at the same time, I'm not very comfortable ignoring non-0 codes, since you never know, when something actually breaks.

image

mehulkar avatar Nov 02 '23 17:11 mehulkar

This was done to support the ignored build step on Vercel (docs):

If the command exits with code 1, the build continues as normal If the command exits with code 0, the build is immediately aborted, and the deployment state is set to CANCELED

tknickman avatar Nov 03 '23 19:11 tknickman

@tknickman yeah agreed, but I think the ask to have an alternate behavior so it can be used in scripting is reasonable too. Although we might want to solve that some other way

mehulkar avatar Nov 03 '23 22:11 mehulkar

plus 1

appleseed-iii avatar Nov 16 '23 17:11 appleseed-iii