turbo icon indicating copy to clipboard operation
turbo copied to clipboard

fix: refactor arg separator strategy

Open cdaringe opened this issue 3 years ago • 4 comments

Problem

See #1477, supersedes #1493

Solution

  • port arg detection into the packagemanager abstraction
  • add version tracking into the struct, as arg separator is often contingent on version
  • port CLI version reading into a shared impl for all package managers

cdaringe avatar Jul 11 '22 06:07 cdaringe

@cdaringe is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 11 '22 06:07 vercel[bot]

hey @nathanhammond, it's been a few weeks. were you able to take a peek yet?

cdaringe avatar Jul 25 '22 21:07 cdaringe

Thanks @cdaringe will take a look.

gaspar09 avatar Jul 28 '22 03:07 gaspar09

Any progress?

flex-jonghyen avatar Aug 02 '22 11:08 flex-jonghyen

@cdaringe Is this PR still needed after #1612?

chris-olszewski avatar Aug 15 '22 20:08 chris-olszewski

Closing this as it is believed addressed by #1612

nathanhammond avatar Aug 30 '22 10:08 nathanhammond