title icon indicating copy to clipboard operation
title copied to clipboard

fix(title): fix copying on WSL 2 by bumping clipboardy version

Open bryan-hoang opened this issue 4 years ago • 3 comments

Commit message

In this PR, support for WSL was added in clipboardy v2.3.0. Since WSL support for title would be nice, clipboardy's version was increased from 1.2.2 to 3.0.0.

Because clipboardy is now an ES module, the method of importing it had to change to use the import function rather than require.

Additional information

After testing locally in WSl 2, I've confirmed that the changes does enable auto-copying on WSL to function as described. When I ran the tests, they all passed. Albeit, it was on Node v17.0.1.

There is no engines field in the package.json file specifying the node version, so I'm unsure if this PR would count as a breaking change to using import.

Please let me know of any changes I should make!

bryan-hoang avatar Nov 15 '21 06:11 bryan-hoang

Are you interested in tackling https://github.com/vercel/title/issues/69?

leerob avatar Feb 12 '22 21:02 leerob

Are you interested in tackling #69?

After reading through the ticket and the linked gist, I would say I'm interested in trying to address it!

bryan-hoang avatar Feb 14 '22 01:02 bryan-hoang

Awesome, yeah I figured I'd mention that since it's related to this PR.

leerob avatar Feb 16 '22 04:02 leerob

it would be nice to have this fix since it also fix vulnerabilities issue for using exec 0.8.0

vaudy avatar Feb 07 '23 16:02 vaudy

It looks like project now uses pnpm to manage the dependencies, making this PR obsolete. I do want to take a stab at #69 like I promised to, so I'll close this PR and reopen another one that aims to address #69 as well as the dependency issue for clipboardy.

bryan-hoang avatar Sep 12 '23 03:09 bryan-hoang

#83 includes updating clipboardy to v3.0.0.

bryan-hoang avatar Sep 17 '23 00:09 bryan-hoang