serve icon indicating copy to clipboard operation
serve copied to clipboard

Don't show VMware Network Address

Open nnnbbb opened this issue 4 years ago • 1 comments

My computer is installed VMware, http://192.168.62.1 Is the network address of the VMware

   ┌──────────────────────────────────────────────────┐
   │                                                  │
   │   Serving!                                       │
   │                                                  │
   │   - Local:            http://localhost:5000      │
   │   - On Your Network:  http://192.168.62.1:5000   │
   │                                                  │
   │   Copied local address to clipboard!             │
   │                                                  │
   └──────────────────────────────────────────────────┘

if (family === 'IPv4' && !internal) {https://github.com/vercel/serve/blob/30b06737b41fcab9d0a49bbac8a9b598869550f4/bin/serve.js#L181

fix:

      if (family === 'IPv4' && !internal && name === 'WLAN') {

nnnbbb avatar Sep 18 '21 02:09 nnnbbb

personally, I would disagree..

this would prevent a notification message when the network adapter is:

  • wired ethernet
  • a virtual machine in "Bridged Adapter" network mode
    • "Internal Network" and "Host-only Adapter" could also be useful, depending on needs
  • etc...

warren-bank avatar Feb 11 '22 20:02 warren-bank